Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix another typo in gininsert.c

  2. Fix typos in gininsert.c

  1. [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Xingbin She <xingbin.she@qq.com> — 2025-12-19T02:47:22Z

    Hi hackers,

This patch fixs a typo in gin code comments, detial as follows:

diff --git a/src/backend/access/gin/gininsert.c b/src/backend/access/gin/gininsert.c
index df30dcc..8824607 100644
--- a/src/backend/access/gin/gininsert.c
+++ b/src/backend/access/gin/gininsert.c
@@ -1784,7 +1784,7 @@ _gin_parallel_merge(GinBuildState *state)
                                                                         ++numtuples);
        }

-       /* relase all the memory */
+       /* release all the memory */
        GinBufferFree(buffer);

        tuplesort_end(state->bs_sortstate);
@@ -1972,7 +1972,7 @@ _gin_process_worker_data(GinBuildState *state, Tuplesortstate *worker_sort,
                GinBufferReset(buffer);
        }

-       /* relase all the memory */
+       /* release all the memory */
        GinBufferFree(buffer);

--
Best regards,
Xingbin SHE
Email: xingbin.she@qq.com

  2. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Michael Paquier <michael@paquier.xyz> — 2025-12-19T02:52:49Z

    On Fri, Dec 19, 2025 at 10:47:22AM +0800, Xingbin She wrote:
> This patch fixs a typo in gin code comments, detial as follows:

Yep, will fix.  Thanks for the report!
--
Michael

  3. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Tender Wang <tndrwang@gmail.com> — 2025-12-19T05:55:14Z

    Hi Michael,

Michael Paquier <michael@paquier.xyz> 于2025年12月19日周五 10:53写道：

> On Fri, Dec 19, 2025 at 10:47:22AM +0800, Xingbin She wrote:
> > This patch fixs a typo in gin code comments, detial as follows:
>
> Yep, will fix.  Thanks for the report!
> --
> Michael


I just found another typo in gininsert.c(maybe on a new thread)
Comments for _gin_build_tuple():

"
 * For by-reference data types, we store the actual data. For by-val types
 * we simply copy the whole Datum, so that we don't have to care about stuff
 * like endianess etc.
"

"endianess" should be "endianness".

-- 
Thanks,
Tender Wang

  4. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Michael Paquier <michael@paquier.xyz> — 2025-12-20T00:24:03Z

    On Fri, Dec 19, 2025 at 01:55:14PM +0800, Tender Wang wrote:
> I just found another typo in gininsert.c(maybe on a new thread)
> Comments for _gin_build_tuple():
> 
> "
>  * For by-reference data types, we store the actual data. For by-val types
>  * we simply copy the whole Datum, so that we don't have to care about stuff
>  * like endianess etc.
> "
> 
> "endianess" should be "endianness".

Indeed.  Thanks.
--
Michael

  5. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Chao Li <li.evan.chao@gmail.com> — 2025-12-20T00:31:28Z

    
> On Dec 20, 2025, at 08:24, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Fri, Dec 19, 2025 at 01:55:14PM +0800, Tender Wang wrote:
>> I just found another typo in gininsert.c(maybe on a new thread)
>> Comments for _gin_build_tuple():
>> 
>> "
>> * For by-reference data types, we store the actual data. For by-val types
>> * we simply copy the whole Datum, so that we don't have to care about stuff
>> * like endianess etc.
>> "
>> 
>> "endianess" should be "endianness".
> 
> Indeed.  Thanks.
> --
> Michael

I found that earlier, but when I checked with https://www.onelook.com/?w=endianess, it has two matches, so I guessed that spelling is acceptable.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  6. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Michael Paquier <michael@paquier.xyz> — 2025-12-21T22:22:25Z

    On Sat, Dec 20, 2025 at 08:31:28AM +0800, Chao Li wrote:
> I found that earlier, but when I checked with
> https://www.onelook.com/?w=endianess, it has two matches, so I
> guessed that spelling is acceptable.

I've always heard only about the spelling with two 'n', the one you
are pointing at being a redirection to the two-n version as well.
Additionally, the rest of the tree seems to agree with that:
$ git grep endianness | wc -l
13
$ git grep endianess | wc -l
0
--
Michael

  7. Re: [PATCH v1] Fixed a spelling error in the comments in gininsert.c

    Chao Li <li.evan.chao@gmail.com> — 2025-12-22T00:47:14Z

    
> On Dec 22, 2025, at 06:22, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Sat, Dec 20, 2025 at 08:31:28AM +0800, Chao Li wrote:
>> I found that earlier, but when I checked with
>> https://www.onelook.com/?w=endianess, it has two matches, so I
>> guessed that spelling is acceptable.
> 
> I've always heard only about the spelling with two 'n', the one you
> are pointing at being a redirection to the two-n version as well.
> Additionally, the rest of the tree seems to agree with that:
> $ git grep endianness | wc -l
> 13
> $ git grep endianess | wc -l
> 0
> --
> Michael

I have no objection at all.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/