Horton

Re: Fix memory leak in gist_page_items() of pageinspect

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Japin Li <japinli@hotmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Chao Li <li.evan.chao@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-19T10:26:55Z
Lists: pgsql-hackers

Attachments

Hi,

On Fri, Dec 19, 2025 at 05:36:51PM +0800, Japin Li wrote:
> On Fri, 19 Dec 2025 at 08:23, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:
> > Yeah that would not hurt. What about before the relation_open() calls?
> >
> > "
> > Use relation_open() and not index_open() to avoid the validate_relation_kind()
> > check as we handle relation validation separately below.
> > "
> >
> 
> LGTM.

Thanks! Done that way in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com