Re: Sequence Access Methods, round two

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Xuneng Zhou <xunengzhou@gmail.com>

Cc: Andrei Lepikhov <lepihov@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Kirill Reshke <reshkekirill@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-12-19T07:33:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor init_params() in sequence.c to not use FormData_pg_sequence_data
- ba3d93b2e806 19 (unreleased) landed
Fix comment thinko in sequence.c
- 17a3f79f812c 17.0 landed
Group more closely cache updates for backends in sequence.c
- 6e951bf98e2e 17.0 landed
Introduce sequence_*() access functions
- 449e798c77ed 17.0 landed

Attachments

v26-0001-Integrate-addition-of-attributes-for-sequences-w.patch (text/x-diff) patch v26-0001
v26-0002-Refactor-code-for-in-core-local-sequences.patch (text/x-diff) patch v26-0002
v26-0003-Sequence-access-methods-backend-support.patch (text/x-diff) patch v26-0003
v26-0004-Sequence-access-methods-dump-restore-support.patch (text/x-diff) patch v26-0004
v26-0005-Sequence-access-methods-core-documentation.patch (text/x-diff) patch v26-0005
v26-0006-Refactor-logic-for-page-manipulations-of-sequenc.patch (text/x-diff) patch v26-0006
v26-0007-snowflake-Add-sequence-AM-based-on-it.patch (text/x-diff) patch v26-0007

On Fri, Dec 19, 2025 at 02:45:47PM +0800, Xuneng Zhou wrote:
> Thanks for working on this. I tried to review patch set v25, but I
> wasn’t able to apply it cleanly on HEAD.

Strange.  It rebases correctly even on today's HEAD at 5cdbec5aa9dc.

> We have two macros the same here.
> 
> 2. Duplicate stmt->tableElts = NIL; in sequence.c:

It looks like I have fat-fingered some rebases here.

> Should we update this to "seq_local_redo: unknown op code %u”?

Yep, thanks.
--
Michael