Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Rename regress.so's .mo file to postgresql-regress-VERSION.mo.

  2. Revert "Avoid requiring Spanish locale to test NLS infrastructure."

  3. Avoid requiring Spanish locale to test NLS infrastructure.

  1. pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-12-15T23:38:01Z

    Revert "Avoid requiring Spanish locale to test NLS infrastructure."

This reverts commit 7db6809ced4406257a80766e4109c8be8e1ea744.
That doesn't seem to work with recent (last couple of years)
glibc, and the reasons are obscure.  I can't let the farm stay
this broken for long.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/84a3778c79c2d28b4dc281d03ef2ab019b16483b

Modified Files
--------------
src/test/regress/expected/nls.out   |  65 ++++++++++-----
src/test/regress/expected/nls_1.out |  49 ++++++-----
src/test/regress/expected/nls_2.out |  35 ++++++++
src/test/regress/po/C.po            | 161 ------------------------------------
src/test/regress/po/LINGUAS         |   2 +-
src/test/regress/po/es.po           | 159 +++++++++++++++++++++++++++++++++++
src/test/regress/regress.c          |  45 +++++-----
src/test/regress/sql/nls.sql        |  35 ++++++--
8 files changed, 314 insertions(+), 237 deletions(-)

  2. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Christoph Berg <myon@debian.org> — 2025-12-17T11:36:50Z

    Re: Tom Lane
> src/test/regress/po/es.po           | 159 +++++++++++++++++++++++++++++++++++

The Debian package builds are complaining that there is now a
usr/share/locale/es/LC_MESSAGES/regress-19.mo
file that needs sorting into one of the .deb packages.

Since regress.so itself doesn't get installed by autoconf's Makefiles,
shouldn't that .mo file not get installed either? (Or resolve it the
other way round and install both.)

Christoph

  3. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Christoph Berg <myon@debian.org> — 2025-12-17T11:57:01Z

    Re: Tom Lane
> src/test/regress/po/es.po           | 159 +++++++++++++++++++++++++++++++++++

The Debian package builds are complaining that there is now a
usr/share/locale/es/LC_MESSAGES/regress-19.mo
file that needs sorting into one of the .deb packages.

Since regress.so itself doesn't get installed by autoconf's Makefiles,
shouldn't that .mo file not get installed either? (Or resolve it the
other way round and install both.)

Christoph

  4. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-12-17T15:29:31Z

    Christoph Berg <myon@debian.org> writes:
> The Debian package builds are complaining that there is now a
> usr/share/locale/es/LC_MESSAGES/regress-19.mo
> file that needs sorting into one of the .deb packages.
> Since regress.so itself doesn't get installed by autoconf's Makefiles,
> shouldn't that .mo file not get installed either? (Or resolve it the
> other way round and install both.)

Hm.  I don't really care to revisit the decision not to install
regress.so.  OTOH, if we don't install the .mo file, "make
installcheck" will not work, which is surely a nonstarter.
(Also, I see no provisions in either build system to build a
non-installed .mo file.)

Is it possible to override that packaging complaint?

			regards, tom lane

  5. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Christoph Berg <myon@debian.org> — 2025-12-17T15:55:07Z

    Re: Tom Lane
> Is it possible to override that packaging complaint?

Sure, we'd just have to install it. It just seemed asymmetric to do
that when regress.so isn't installed. (TBH I've been pondering to do
that anyway to make re-running the regression tests later easier.)

"regress-19.mo" is a pretty generic name for a file installed in a
system-wide location. Perhaps it could be named postgresql-regress-19.mo?
(pg_regress(-19).mo doesn't exist yet, but might appear independently.)

Christoph

  6. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-12-17T15:57:56Z

    Christoph Berg <myon@debian.org> writes:
> "regress-19.mo" is a pretty generic name for a file installed in a
> system-wide location. Perhaps it could be named postgresql-regress-19.mo?
> (pg_regress(-19).mo doesn't exist yet, but might appear independently.)

Fair point, I'll look into renaming that later.

			regards, tom lane

  7. Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-12-17T19:11:38Z

    I wrote:
> Christoph Berg <myon@debian.org> writes:
>> "regress-19.mo" is a pretty generic name for a file installed in a
>> system-wide location. Perhaps it could be named postgresql-regress-19.mo?
>> (pg_regress(-19).mo doesn't exist yet, but might appear independently.)

> Fair point, I'll look into renaming that later.

Done at 5b4fb2b97d2.

			regards, tom lane