Re: Change the signature of pgstat_report_vacuum() so that it's passed a Relation

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andres Freund <andres@anarazel.de>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Chao Li <li.evan.chao@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-12-17T02:48:44Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Change pgstat_report_vacuum() to use Relation
- f4e797171eac 19 (unreleased) landed

On Tue, Dec 16, 2025 at 09:55:09AM -0500, Andres Freund wrote:
> On 2025-12-16 09:45:34 +0000, Bertrand Drouvot wrote:
>> But, we can't do the same for pgstat_report_analyze() because pgstat_should_count_relation()
>> can modify the relation through pgstat_assoc_relation(). So I'm inclined to
>> let it as in v1. Thoughts?
> 
> I think const markings for things like this just means more code churn or ugly
> casts when it inevitably ends up not working at some point.

I'm unconvinced as well by the addition of some consts here, so I've
applied v1.
--
Michael