Thread

Re: Fix and improve allocation formulas

Bruce Momjian <bruce@momjian.us> — 2025-12-24T20:19:32Z

On Thu, Dec 11, 2025 at 05:56:13PM +0100, Álvaro Herrera wrote:
> On 2025-Dec-11, Andres Freund wrote:
> 
> > a) changing over everything at once is worth the backpatch hazard and review
> >    pain
> 
> The other issue with these giant patches is that they cause many largish
> patches waiting in the commitfest process to require rebases, which are
> sometimes not trivial to do.  Also, all the Postgres forks will
> require tedious merges later on.
> 
> I have my part of blame for having committed the mass change to
> XLogRecPtrIsValid in a2b02293bc65.  I'm starting to regret that now.

I think the bigger issue is that these patches bypass the normal
workflow of implementing changes in Postgres --- specifically, asking
about Desirability first:

	https://wiki.postgresql.org/wiki/Todo
	Desirability -> Design -> Implement -> Test -> Review -> Commit

It would have been much cleaner to discuss the desirability of this
change on its own.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.