Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Chao Li <li.evan.chao@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Aleksander Alekseev <aleksander@tigerdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Bruce Momjian <bruce@momjian.us>

Date: 2025-12-11T21:43:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent: improve formatting of multiline comments.
- 60f9467c3834 19 (unreleased) landed
Adjust style of some debugging macros.
- ba1e14134a77 19 (unreleased) landed
Fix a couple of comments.
- 123661427b97 19 (unreleased) landed
Add IGNORE NULLS/RESPECT NULLS option to Window functions.
- 25a30bbd4235 19 (unreleased) cited
Split WaitEventSet functions to separate source file
- 393e0d231405 18.0 cited

Attachments

v1-0001-fix-some-commented-undefs.patch (text/plain)

On Tue, Oct 28, 2025 at 08:36:33AM +0800, Chao Li wrote:
> On Oct 28, 2025, at 07:35, Michael Paquier <michael@paquier.xyz> wrote:
>> On Mon, Oct 27, 2025 at 09:55:38AM -0500, Nathan Bossart wrote:
>>> /*
>>>  * DISABLE_LEADER_PARTICIPATION disables the leader's participation in
>>>  * parallel index builds.  This may be useful as a debugging aid.
>>> -#undef DISABLE_LEADER_PARTICIPATION
>>> + *#undef DISABLE_LEADER_PARTICIPATION
>>>  */
>>> 
>>> IMHO we should either remove this line or move it out of the comment.
>>> AFAICT we ordinarily don't #undef debugging stuff like this, presumably so
>>> you can change it with compile flags.
>> 
>> I would put this one on a separate line, outside the comment.  It's
>> minor, still we use this style in pg_config_manual.h.  See around
>> REALLOCATE_BITMAPSETS.
> 
> +1

Here's a patch for this.  I also changed the #undefs to #defines.

-- 
nathan