Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. tests: Rename conflicting role names

  1. backpatch tests: Rename conflicting role names to 14/15

    Sami Imseih <samimseih@gmail.com> — 2025-12-10T22:39:11Z

    Hi,

On 15 STABLE, I encountered the same issue [0] which was fixed in 6a20b04f0408
starting from 16. It seems like a decision not to backpatch to lower
versions at the
time was due to a lack of reports [1], but I think since we have to
support 14 and 15 for
a few more years, it makes sense to. I can prepare the patches if there are no
objections.

[0] https://www.postgresql.org/message-id/flat/ZvTneMVPdsMYwTQE%40paquier.xyz#162ef382dde245fd903464e66b37809b
[1] https://postgr.es/m/20221003234111.4ob7yph6r4g4ywhu@awork3.anarazel.de

--
Sami Imseih
Amazon Web Services (AWS)

  2. Re: backpatch tests: Rename conflicting role names to 14/15

    Michael Paquier <michael@paquier.xyz> — 2025-12-10T22:53:55Z

    On Wed, Dec 10, 2025 at 04:39:11PM -0600, Sami Imseih wrote:
> On 15 STABLE, I encountered the same issue [0] which was fixed in 6a20b04f0408
> starting from 16.  It seems like a decision not to backpatch to lower
> versions at the time was due to a lack of reports [1], but I think since we have to
> support 14 and 15 for a few more years, it makes sense to.

The issue is that Sami has been able to trigger this problem
internally.  :)

> I can prepare the patches if there are no objections.

If you could prepare a patch, that would be great!  Let's do that if
v14 and v15 can also face the issue under a high-concurrent build.
The blast area of 6a20b04f0408 is not that bad.
--
Michael

  3. Re: backpatch tests: Rename conflicting role names to 14/15

    Sami Imseih <samimseih@gmail.com> — 2025-12-11T00:57:56Z

    > > I can prepare the patches if there are no objections.
>
> If you could prepare a patch, that would be great!  Let's do that if
> v14 and v15 can also face the issue under a high-concurrent build.
> The blast area of 6a20b04f0408 is not that bad.

"make-installcheck --jobs 8" has reproduced the conflict almost
consistently between adminpack and plperl tests.

cherry-pick to 15 had no conflicts. 14 does not have the
plperl_setup_scratch schema, so I had to fix that.

See the attached.

--
Sami Imseih
Amazon Web Services

  4. Re: backpatch tests: Rename conflicting role names to 14/15

    Michael Paquier <michael@paquier.xyz> — 2025-12-12T00:10:50Z

    On Wed, Dec 10, 2025 at 06:57:56PM -0600, Sami Imseih wrote:
> "make-installcheck --jobs 8" has reproduced the conflict almost
> consistently between adminpack and plperl tests.
> 
> cherry-pick to 15 had no conflicts. 14 does not have the
> plperl_setup_scratch schema, so I had to fix that.
> 
> See the attached.

Thanks for the patches.  These look correct, so applied to v15 and
v14.
--
Michael