Thread

Re: BUG #19095: Test if function exit() is used fail when linked static

Michael Paquier <michael@paquier.xyz> — 2025-12-04T00:32:03Z

On Thu, Dec 04, 2025 at 12:33:55AM +0100, Daniel Gustafsson wrote:
> Thanks for the update.  This patch builds on previous patches posted in the
> thread which makes it more complicated to review.  Can you please post a full
> squashed patch against master so we can be absolutely sure we are looking at
> the tree in the same state that you are.

Yeah, I was just playing with this patch a little bit this morning,
and reworked it as the attached, adjusting a bunch of stuff inside it.
The main complaint that I have with v4 is the fact that the new check
for pthread_exit() was not split as a patch of its own, being hidden
in the perl script introduced.

Saying that, passing the path of nm as argument to the perl script is
something that feels OK here, as does the coverage check added twice
for meson and Makefile, rather than relying on enable_coverage in an
ENV.  Feel free to comment on these points, of course.

There were a few other things (comments, etc.) that I have tweaked
(commit message not edited, stolen from v4), but feel free to see the
attached for all the details.  libpq fails properly after planting
some exit() calls reported by nm.  I have run once autoreconf while on
it, before running a check in the CI, which was also OK.
--
Michael