Horton
Menu

Re: Remove useless pointer advance in StatsShmemInit()

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2025-12-03T15:55:40Z
Lists: pgsql-hackers 
Hi,

On Wed, Dec 03, 2025 at 10:13:55AM -0500, Andres Freund wrote:
> On 2025-12-03 08:14:41 +0000, Bertrand Drouvot wrote:
> > So, what about documenting them all?
> 
> I'm -0.1 on that. I think it's just as likely that those code comments will
> not be moved when another chunk of memory is needed and cause confusion that
> way. Sorry, but to me this is just a case of restating obvious code in an
> obvious mechanical comment.

No problem at all, thanks for sharing your thoughts!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove useless pointer update in StatsShmemInit()