Re: [Proposal] Adding callback support for custom statistics kinds

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Sami Imseih <samimseih@gmail.com>

Cc: Chao Li <li.evan.chao@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-12-13T02:00:30Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix const correctness in pgstat data serialization callbacks
- 167cb26718e3 19 (unreleased) landed
test_custom_stats: Add tests with read/write of auxiliary data
- 481783e69f14 19 (unreleased) landed
Allow cumulative statistics to read/write auxiliary data from/to disk
- 4ba012a8ed9c 19 (unreleased) landed
test_custom_stats: Test module for custom cumulative statistics
- 31280d96a648 19 (unreleased) landed
injection_points: Remove portions related to custom pgstats
- d52c24b0f808 19 (unreleased) landed
Rename routines for write/read of pgstats file
- ed823da12891 19 (unreleased) landed

On Fri, Dec 12, 2025 at 06:41:20PM -0600, Sami Imseih wrote:
> I made some changes as well, in v8:
> 
> 1/ looks like b4cbc106a6ce snuck into v7. I fixed that.

Oops, sorry about that.  I went one reset too deep..  I can see that
my local branch was also wrong, an a rebase fixed it immediately.

> 2/ After looking this over, I realized that “extra” and “auxiliary”
> were being used interchangeably. To avoid confusion, I replaced all
> instances of “extra” with “auxiliary" in both the comments and
> macros, i.e. TEST_CUSTOM_AUX_DATA_DESC

I can see what you have changed in v8 compared to v7, in terms of the
elog(), the comments and TEST_CUSTOM_AUX_DATA_DESC.  That works for
me.  If somebody has a better idea for a name, these can always be
tweaked at will.
--
Michael