Horton

Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

Nathan Bossart <nathandbossart@gmail.com>

View thread
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-11T22:39:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow passing a pointer to GetNamedDSMSegment()'s init callback.

  2. Move dynamically-allocated LWLock tranche names to shared memory.

Thanks for the new patch.

On Thu, Dec 11, 2025 at 04:12:02PM -0600, Sami Imseih wrote:
> I went back-forth on if it makes sense to provide the name as an
> extra argument and decided it provides more flexibility. For example
> I can use the same init callback and arguments for different segments.

If the initialization callback function needed the name, it could be
provided via the "void *" callback argument, right?  I'm not following why
we need to provide it separately.

-- 
nathan