Re: Proposal: Add a callback data parameter to GetNamedDSMSegment

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Sami Imseih <samimseih@gmail.com>

Cc: Zsolt Parragi <zsolt.parragi@percona.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-12-13T16:08:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow passing a pointer to GetNamedDSMSegment()'s init callback.
- 48d4a1423d2e 19 (unreleased) landed
Move dynamically-allocated LWLock tranche names to shared memory.
- 38b602b0289f 19 (unreleased) cited

On Sat, Dec 13, 2025 at 08:21:58AM -0600, Sami Imseih wrote:
> I was just using an Assert in v6 to test the pointer value, which is
> not what we want for testing. Better to have a error with proper logging.
> I fixed that in v7.

LGTM at a glance.  I didn't see a cfest entry for this one.  Can you add
one so that we get some CI test coverage?

-- 
nathan