Re: Fix memory leak in gist_page_items() of pageinspect

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Chao Li <li.evan.chao@gmail.com>

Cc: Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-12-15T04:08:44Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Use relation_close() more consistently in contrib/
- 8b9b93e39b10 19 (unreleased) landed
Use table/index_close() more consistently
- 9d0f7996e58c 19 (unreleased) landed
pageinspect: use index_close() for GiST index relation
- 171198ff2a57 19 (unreleased) landed

On Sat, Dec 13, 2025 at 10:37:40AM +0800, Chao Li wrote:
> So I’ve split the fix into two commits, which I probably should have done
> from the beginning. 0001 contains the index_close() fix, and 0002 contains
> the StringInfo fix.

While passing through, I have applied 0001.  (Note that the email
address you have added to the commit message of 0001 did not match
with your actual email address, perhaps you did not intend to do
that..)
--
Michael