Re: Refactoring: Use soft error reporting for *_opt_overflow functions of date/timestamp

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Amit Langote <amitlangote09@gmail.com>

Cc: Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-28T00:46:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Update some timestamp[tz] functions to use soft-error reporting
- 713d9a847e64 19 (unreleased) landed
Switch some date/timestamp functions to use the soft error reporting
- d03668ea0566 19 (unreleased) landed
Switch some numeric-related functions to use soft error reporting
- 4246a977bad6 19 (unreleased) cited

On Thu, Nov 27, 2025 at 06:18:32PM +0900, Amit Langote wrote:
> On Thu, Nov 27, 2025 at 4:58 PM Amul Sul <sulamul@gmail.com> wrote:
>> One question: Regarding date2timestamp_no_overflow(), should we rename
>> it to date2double? We can't use date2timestamp_safe because we already
>> have that function. The renaming is relevant because this function
>> converts a date to the double data type, which allows us to remove the
>> "_no_overflow" extension.
> 
> Makes sense to me.

Yes, it would be nice to change all this area at once to remain
consistent across the board.  date2timestamp_no_overflow() is the last
"no_overflow" routine in date.h.
--
Michael