Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Fix typo in pg_dump documentation

  2. doc: Fix incorrect wording for --file in pg_dump

  1. pgsql: doc: Fix incorrect wording for --file in pg_dump

    Daniel Gustafsson <dgustafsson@postgresql.org> — 2025-11-07T14:27:42Z

    doc: Fix incorrect wording for --file in pg_dump

The documentation stated that the directory specified by --file
must not exist, but pg_dump does allow for empty directories to
be specified and used.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Bruce Momjian <bruce@momjian.us>
Discussion: https://postgr.es/m/534AA60D-CF6B-432F-9882-E9737B33D1B7@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f

Modified Files
--------------
doc/src/sgml/ref/pg_dump.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

  2. Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

    Erik Rijkers <er@xs4all.nl> — 2025-11-27T05:48:56Z

    Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
> 
> Modified Files
> --------------
> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:

"unless the directory exist and is empty." should be
"unless the directory exists and is empty."

i.e., 'exists': because 'directory' is singular.

Thanks!

Erik

  3. Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

    Chao Li <li.evan.chao@gmail.com> — 2025-11-27T06:32:21Z

    
> On Nov 27, 2025, at 13:48, Erik Rijkers <er@xs4all.nl> wrote:
> 
> Op 11/7/25 om 15:27 schreef Daniel Gustafsson:
>> Branch
>> ------
>> master
>> Details
>> -------
>> https://git.postgresql.org/pg/commitdiff/07961ef86625be91e243f1dff8911cb1d70e443f
>> Modified Files
>> --------------
>> doc/src/sgml/ref/pg_dump.sgml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Hi,
> 
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
> 
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
> 
> i.e., 'exists': because 'directory' is singular.
> 

+1, agreed.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  4. Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

    Michael Paquier <michael@paquier.xyz> — 2025-11-27T06:33:39Z

    On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
> 
> "unless the directory exist and is empty." should be
> "unless the directory exists and is empty."
> 
> i.e., 'exists': because 'directory' is singular.

Indeed, good catch.  Daniel will very likely show up.  If not, I'll go
apply a fix.
--
Michael

  5. Re: pgsql: doc: Fix incorrect wording for --file in pg_dump

    Daniel Gustafsson <dgustafsson@postgresql.org> — 2025-11-27T09:32:27Z

    > On 27 Nov 2025, at 07:33, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Thu, Nov 27, 2025 at 06:48:56AM +0100, Erik Rijkers wrote:
>> In doc/src/sgml/ref/pg_dump.sgml, a tiny typo:
>> 
>> "unless the directory exist and is empty." should be
>> "unless the directory exists and is empty."
>> 
>> i.e., 'exists': because 'directory' is singular.
> 
> Indeed, good catch.  Daniel will very likely show up.  If not, I'll go
> apply a fix.

Done, sorry for the delay.

--
Daniel Gustafsson