Horton

Re: pgsql: Drop unnamed portal immediately after execution to completion

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Mircea Cadariu <cadariu.mircea@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Frédéric Yhuel <frederic.yhuel@dalibo.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-14T22:13:42Z
Lists: pgsql-hackers 
On Fri, Nov 14, 2025 at 03:10:32PM +0000, Mircea Cadariu wrote:
> What's interesting about the holdable cursors scenario is that as far as I
> can tell the temp files are cleaned up during PersistHoldablePortal instead
> of PortalDrop.

As part of the ExecutorEnd() done in this case.  Right, it looks like
a good thing to track this behavior as well in the long-run.  I'll
double-check that later.
--
Michael

Commits

  1. Add test for temporary file removal and WITH HOLD cursor

  2. Revert "Drop unnamed portal immediately after execution to completion"

  3. Drop unnamed portal immediately after execution to completion