Horton

Re: postgresql.conf.sample tab width

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2025-11-14T21:30:07Z
Lists: pgsql-hackers

Attachments

On Fri, Nov 14, 2025 at 03:25:15PM -0500, Tom Lane wrote:
> I seem to recall a proposal that the best fix is to not use tabs
> at all in postgresql.conf.sample.  That seems like a good way out
> to me.  I think we could fix .gitattributes so that "git diff --check"
> would verify no tabs, but I've not looked into details.

I don't see a way in .gitattributes to check for _any_ tabs in a file, just
for beginning-of-line indentation with tabs.  But it's easy enough to add a
check in the TAP test.

-- 
nathan

Commits

  1. Check for tabs in postgresql.conf.sample.

  2. Switch from tabs to spaces in postgresql.conf.sample.

  3. Update .editorconfig and .gitattributes for postgresql.conf.sample.