Re: Uncommented GUC in postgresql.conf.sample
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-14T14:51:03Z
Lists: pgsql-hackers
On Fri, Nov 14, 2025 at 09:44:42AM -0500, Tom Lane wrote: > Daniel Gustafsson <daniel@yesql.se> writes: > > When looking at the nearby suggestion to add deprecation comment for md5 in the > > .conf.sample, I happened to notice that autovacuum_worker_slots isn't commented > > out it the sample file. > > > AFAIK all GUCs in the sample file should be set to their defaults and left > > commented out. > > Yes, that is surely a bug. It should be fixed and back-patched. Yes, but again, be aware that only new initdb's will see this change. People doing a diff against an old postgresql.conf file and a new initdb's postgresql.conf.sample in the same major release might see this change and think they did it. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
Commits
-
Add test for postgresql.conf.sample line syntax
- 446568c22207 19 (unreleased) landed
-
Comment out autovacuum_worker_slots in postgresql.conf.sample.
- c73213992471 18.2 landed
- 478c4814a052 19 (unreleased) landed