Re: Few untranslated error messages in OAuth

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Jacob Champion <jacob.champion@enterprisedb.com>

Date: 2025-11-13T06:47:54Z

Lists: pgsql-hackers

On Thu, Nov 13, 2025 at 06:01:29AM +0000, Zhijie Hou (Fujitsu) wrote:
> During testing of libpq, I noticed several error messages not processed by
> libpq_gettext, resulting in their exclusion from *.pot files. The attached patch
> wraps these messages.

(Added Jacob and Daniel in CC.)

async_ctx says that errcxt "will be translated for you.", but these
are missing from the translation files.  So yes, it looks like you are
right.
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

libpq: Align oauth_json_set_error() with other NLS patterns
- 7a15cff1f111 18.2 landed
- f7fbd02d32c4 19 (unreleased) landed
libpq-oauth: Don't translate internal errors
- aac25567fec1 18.2 landed
- 301a1dcf00c8 19 (unreleased) landed
libpq: Add missing OAuth translations
- 169ff4ca930b 18.2 landed
- ea3370b18ebe 19 (unreleased) landed