Re: obsolete autovacuum comment
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: pgsql-hackers@postgresql.org
Date: 2025-11-12T21:13:32Z
Lists: pgsql-hackers
On Wed, Nov 12, 2025 at 06:09:40PM +0100, Álvaro Herrera wrote: > The comment you cite appears more or less in the same place in > autovacuum-6.patch (the routine was called test_rel_for_autovac there), > but I think what it really is about, is the AVOperUpdateCounts operation > that was in autovacuum-5.patch. Note that that older patch was > introducing a new pg_autovacuum catalog which kept track of tuple counts > since last analyze/vacuum, and those counts needed to be updated in case > pgstats was reset. But by patch autovacuum-6.patch this had disappeared > (the counts were now in pgstats, per review from Tom), so we didn't need > to reset any counters, and the AVOperUpdateCounts operation went away. > > It's quite possible that, having removed the "counter reset" operation > from the proposed patch and reduced the comment to what we have today, > we promptly forgot about the whole thing. So the comment is indeed a > relic that can be removed. I see, thanks for looking. I've committed the patch. -- nathan
Commits
-
Remove obsolete autovacuum comment.
- 180e7abe6804 19 (unreleased) landed
-
Add vacuum and analyze counters to pg_stat_*_tables views.
- 946045f04d11 9.1.0 cited
-
I have updated my pg_autovacuum program (formerly pg_avd, the name
- bd18c50ba87f 7.4.1 cited