Re: obsolete autovacuum comment

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Date: 2025-11-11T20:35:28Z
Lists: pgsql-hackers

Attachments

On Mon, Nov 10, 2025 at 02:03:27PM -0600, Nathan Bossart wrote:
> While working on my autovacuum scheduling patch [0], I noticed the
> following comment in relation_needs_vacanalyze():
> 
>         /*
>          * Note that we don't need to take special consideration for stat
>          * reset, because if that happens, the last vacuum and analyze counts
>          * will be reset too.
>          */
> 
> AFAICT this is a relic from pg_autovacuum (the contrib module and
> predecessor to modern autovacuum) [1] and early versions of the autovacuum
> patch [2] [3].  After digging through the archives [4], I think this is
> referring to some stats that had to be managed separately but weren't ever
> actually committed.

Patch attached.

> Any objections to removing this comment?

If none materialize, I will proceed with removal in a couple of days.

-- 
nathan

Commits

  1. Remove obsolete autovacuum comment.

  2. Add vacuum and analyze counters to pg_stat_*_tables views.

  3. I have updated my pg_autovacuum program (formerly pg_avd, the name