Horton

Re: Add tests for object size limits of injection points

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-10T03:31:50Z
Lists: pgsql-hackers 
On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote:
> Is really confused. The error message says “maximum of 64”, but the
> test right uses a name of length 64. I know that the tricky is the
> ‘\0’ terminator, but should SQL writer have to keep mind about the
> ‘\0’ terminator? Should they just consider maximum length as 63?

Right.  We could add a "- 1" to the error message printed.
--
Michael

Commits

  1. injection_points: Add tests for name limits

  2. Report better object limits in error messages for injection points