Horton

Re: pg_resetwal prints new OldestXID in wrong circumstances

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Date: 2025-11-19T10:05:12Z
Lists: pgsql-bugs 
Hi,

On Wed, Nov 19, 2025 at 11:52:31AM +0200, Heikki Linnakangas wrote:
> Printing the new OldestXID value is incorrectly tied to whether the
> --next-transaction-id option is given, so this prints it, even though
> OldestXID is not being modified:

Nice catch!

> This seems to have been an oversight when the --oldest-transaction-id option
> was added (commit 74cf7d46a91d).

yeah.

> Before that, OldestXID was reset when the
> --next-transaction-id option was given.
> 
> Fix attached. Barring objections, I will commit and backpatch this.

LGTM, thanks!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com