Horton

Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: Noah Misch <noah@leadboat.com>, ryanzxg@gmail.com, pgsql-bugs@lists.postgresql.org, Euler Taveira <euler@eulerto.com>
Date: 2025-11-04T04:52:09Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add assertions checking for the startup process in WAL replay routines

  2. Add assertion check for WAL receiver state during stream-archive transition

  3. Add WalRcvGetState() to retrieve the state of a WAL receiver

  4. Fix unconditional WAL receiver shutdown during stream-archive transition

  5. Add test tracking WAL receiver shutdown for primary_conninfo updates

  6. Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit.

  7. Replace durable_rename_excl() by durable_rename(), take two

  8. Split xlog.c into xlog.c and xlogrecovery.c.

Attachments

On Sat, Nov 01, 2025 at 08:44:55AM +0800, Xuneng Zhou wrote:
> On Sat, Nov 1, 2025 at 8:17 AM Michael Paquier <michael@paquier.xyz> wrote:
>> Thanks, that looks sensible.  I'll revisit what you have at the
>> beginning of next week (local Tuesday) with a backpatch down to v13 in
>> mind.  If others have comments and/or objections, please feel free to
>> chime in.
> 
> It's an oversight. Thanks for catching it.

Phew, done.  While looking at the whole thing, I was wondering if we
should strengthen a little bit what's expected of the context for some
of the callers of the WAL routines, like XLogShutdownWalRcv(), and
finished with the bonus patch attached.  What do you think?
--
Michael