Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "David E. Wheeler" <david@justatheory.com>, Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Date: 2025-10-31T14:09:36Z
Lists: pgsql-hackers 
On Fri, Oct 31, 2025 at 12:02:10PM +0100, Peter Eisentraut wrote:
> What is the reason that this file is supposed to contain the history of
> relevant changes, rather than just the last one?
> 
> If you want the history, you could look at the git log of the file itself,
> no?

I think either way would ultimately be fine.  I might argue that keeping
the full history in a file with detailed explanations is more accessible
than requiring folks to run

	git log .abi-compliance-history

(Plus, if someone doesn't bother to put details in the commit message, you
then have to sleuth further to figure out what changed.)

-- 
nathan

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.