Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Bruce Momjian <bruce@momjian.us>

View thread View on postgr.es
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "David E. Wheeler" <david@justatheory.com>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>, Mankirat Singh <mankiratsingh1315@gmail.com>
Date: 2025-10-30T16:49:23Z
Lists: pgsql-hackers 
On Wed, Oct 29, 2025 at 05:37:36PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Fri, Oct 17, 2025 at 07:07:36PM -0400, Tom Lane wrote:
> >> That seems overcomplicated: how does the buildfarm know
> >> what's a maintenance branch?  I think the rule should be
> >> just "run ABI checks if the control file exists, else not".
> 
> > I assume we would want ABI breakage checks on master between Beta 1 and
> > the time we branch for the new major release in July.
> 
> In the past we've never really thought that ABI was more than mildly
> solidified until around rc1.  On the whole I'd rather wait until after
> the branch before starting to check ABI, simply because I don't care
> for the idea of adding .abi-compliance-history in the master branch
> only to remove it again later.  Having said that, it would be good
> if we *could* choose to do that, so I still do not like having any
> policy decisions about which branches to check hard-wired into the
> buildfarm client.

I guess I would like to be _notified_, in some way, of ABI breaks during
that period.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.