Remove specific \r\n code in TAP for Windows
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Date: 2025-10-24T06:51:11Z
Lists: pgsql-hackers
Attachments
- 0001-Remove-specific-CRLF-code-in-TAP-tests.patch (text/x-diff) patch 0001
Hi all, $subject has been mentioned by Jacob (in CC.) on Discord, and it does not seem like somebody took the time to propose a patch. We use in some places of the TAP tests the following pattern: my $newline = $windows_os ? "\r\n" : "\n"; Two files have this idea: - 003_ldap_connection_param_lookup.pl - 006_service.pl Note: I have committed one of these. However, in light of 1c6d4629394d, we should not require that, and the CI looks happy with the attached. That would be up to the buildfarm to act as final judge, but any objections in attempting to get rid of these like in the attached? I would try first HEAD to be sure, then follow with an optional backpatch. Thoughts? -- Michael
Commits
-
Simplify newline handling in libpq TAP test
- a92bbffbc3a7 18.1 landed
-
Simplify newline handling in two TAP tests
- 8767b449a3a1 19 (unreleased) landed