Re: Avoid resource leak (src/test/regress/pg_regress.c)
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-24T06:03:27Z
Lists: pgsql-hackers
On Thu, Oct 23, 2025 at 09:37:21PM -0300, Ranier Vilela wrote: > The function *config_sspi_auth* is responsible for > rewrite pg_hba.conf and pg_ident.conf to use SSPI authentication. > > Coverity complains that the struct addrinfo gai_result is leaked. > The variable is declared inside block and is not used > outside the block. > > So if the function WSAStartup is successful then the function getaddrinfo > allocates and fills the struct addrinfo. > > The memory must be released at the end of the block. Not sure that this one is worth caring about. We have a bunch of allocations that we know would be freed once a binary exits. This is just one of them, allocated in the context of what is a short-term execution. -- Michael