Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Aleksander Alekseev <aleksander@timescale.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>

Date: 2025-10-23T20:25:15Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgindent: improve formatting of multiline comments.
- 60f9467c3834 19 (unreleased) landed
Adjust style of some debugging macros.
- ba1e14134a77 19 (unreleased) landed
Fix a couple of comments.
- 123661427b97 19 (unreleased) landed
Add IGNORE NULLS/RESPECT NULLS option to Window functions.
- 25a30bbd4235 19 (unreleased) cited
Split WaitEventSet functions to separate source file
- 393e0d231405 18.0 cited

On Mon, Jun 23, 2025 at 01:42:32PM +0300, Aleksander Alekseev wrote:
>> Do we want to skip such comments?
>> I have also seen comments with '====' border.
> 
> Personally I don't have a strong opinion on this. We can easily add an
> exception for "/* ---" and "/* ===" comments if somebody believes this
> is a problem. I choose not to add such an exception just yet only
> because I don't like unnecessary exceptions :)

+1 for adding an exception for "/* -----" style comments.  I tested running
pgindent after applying the patch, and the first thing I noticed was all
these (IMHO) unnecessary changes.  I don't think it helps readability, and
even if it did, it's arguably not worth the churn.

-- 
nathan