Horton

Re: Making pg_rewind faster

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: John H <johnhyvr@gmail.com>, wenhui qiu <qiuwenhuifx@gmail.com>, Japin Li <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>, Alexander Korotkov <aekorotkov@gmail.com>, Justin Kwan <justinpkwan@outlook.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh <vignesh@cloudflare.com>, vignesh ravichandran <admin@viggy28.dev>, "hlinnaka@iki.fi" <hlinnaka@iki.fi>, "jkwan@cloudflare.com" <jkwan@cloudflare.com>
Date: 2025-10-23T05:12:24Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_rewind: Skip copy of WAL segments generated before point of divergence

  2. pg_rewind: Extend code detecting relation files to work with WAL files

  3. Split TESTDIR into TESTLOGDIR and TESTDATADIR

On Thu, Sep 25, 2025 at 02:35:16PM -0400, Robert Haas wrote:
> On a related note, something a committer would need to do if they
> wanted to commit this patch is figure out who should be credited with
> writing it. I see that a number of different people have posted
> versions of the patch; it would be nice if "Author:" or
> "Co-authored-by:" tags were added to the commit message to reflect
> whose code is present in a given version.

Looking at this patch was on my TODO list (more to that in a bit), and
the simplest answer to this question is that everybody involved would
be cited in the release notes.  Justin Kwan has been the original
author.  John Hsu and Srinath have followed up in an equivalent
fashion, including answers with your review comments posted on this
previous message.  So listing all three as equivalent authors feels
normal to me (no need for co-authoring notes, IMO).
--
Michael