Thread

Commits

  1. Fix comment in pg_get_shmem_allocations_numa()

  1. Fix incorrect comment in pg_get_shmem_allocations_numa()

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2025-07-21T09:06:22Z

    Hi hackers,
    
    One comment in pg_get_shmem_allocations_numa() incorrectly describes the function
    as dealing with database blocks when it actually processes shared memory allocations
    from the shmem index.
    
    PFA, a patch to $SUBJECT.
    
    Regards,
    
    -- 
    Bertrand Drouvot
    PostgreSQL Contributors Team
    RDS Open Source Databases
    Amazon Web Services: https://aws.amazon.com
    
  2. Re: Fix incorrect comment in pg_get_shmem_allocations_numa()

    Michael Paquier <michael@paquier.xyz> — 2025-10-21T07:14:39Z

    On Mon, Jul 21, 2025 at 09:06:22AM +0000, Bertrand Drouvot wrote:
    > One comment in pg_get_shmem_allocations_numa() incorrectly describes the function
    > as dealing with database blocks when it actually processes shared memory allocations
    > from the shmem index.
    
    (Noticed this one while browsing the CF app.)
    
    Yep, agreed that the comment deserves a better explanation, so applied
    down to v18.
    --
    Michael