Re: BRIN: Prevent the heapblk overflow during index summarization on very large tables resulting in an infinite loop

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: David Rowley <dgrowleyml@gmail.com>

Cc: sunil s <sunilfeb26@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2025-10-21T05:53:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix BRIN 32-bit counter wrap issue with huge tables
- c28f8ca29445 13.23 landed
- eea24eb0ac2f 14.20 landed
- 810aaf7f2706 15.15 landed
- ef915bf9367c 16.11 landed
- c4f5a59ab16b 17.7 landed
- 715983a81ac8 18.1 landed
- 9fd29d7ff476 19 (unreleased) landed
Fix integer overflow bug in GiST buffering build calculations.
- 4bc6fb57f774 9.2.0 cited

On Tue, Oct 21, 2025 at 06:32:01PM +1300, David Rowley wrote:
> I'd leave it as uint64. There's no reason to mixup the signedness
> between these two variables.

That's fine as well.

> I'm happy to finish this one off. I was leaving it for Tomas to
> comment, but I think he'll be busy with pgconf.eu for the next few
> days.

Cool, thanks.  I'm leaving that stuff up to any of you, have fun.
FWIW, I am on the same line as you.  Your suggestions are better than
what the proposed patch does, as far as I've looked.
--
Michael