Re: Remove specific \r\n code in TAP for Windows

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-27T23:27:35Z
Lists: pgsql-hackers
On Mon, Oct 27, 2025 at 08:33:57AM -0700, Jacob Champion wrote:
> Ah, sorry, I put part of my first attempt at it over in [1]. But I
> realize that's not very visible, nor does it address
> 003_ldap_connection_param_lookup.

Ahh, so you did post something.  I have missed that 


> I'm carrying a local diff that switches 003_ldap_ over to qq{} style.
> Attached in case you like it, but your patch LGTM too.

Your suggestions for the LDAP test are cleaner than what I came up
with, so reused these.

>> That would be up to the buildfarm to act as final judge, but any
>> objections in attempting to get rid of these like in the attached?
>> I would try first HEAD to be sure, then follow with an optional
>> backpatch.
> 
> Sounds like a plan.

Time for a verdict, so applied on HEAD now. 
--
Michael

Commits

  1. Simplify newline handling in libpq TAP test

  2. Simplify newline handling in two TAP tests