Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "David E. Wheeler" <david@justatheory.com>, Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Date: 2025-10-20T18:30:49Z
Lists: pgsql-hackers

Attachments

On Mon, Oct 20, 2025 at 12:14:09PM -0500, Nathan Bossart wrote:
> On Mon, Oct 20, 2025 at 01:07:04PM -0400, Tom Lane wrote:
>> I'd tend to s/placate/control/, otherwise the proposed wording in the
>> file looks good.  I doubt we really need a script to generate the
>> file in the first place -- why wouldn't copying another branch's
>> boilerplate be good enough?  If you're set on having a script,
>> at least make it pre-fill the initial entry.  (Using branch HEAD
>> ought to be good enough for that.)
> 
> I'm fine with leaving out the script if you are.  It was only aimed at
> making the release checklist a little less cumbersome, but even without the
> script it's a whopping minute or two of effort that only needs to happen
> once per year.  I've probably already spent far more time automating it
> than makes sense [0].

Here is an updated patch set.

-- 
nathan

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.