Horton

Re: Remove Item type

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-10-24T15:32:15Z
Lists: pgsql-hackers 
On Mon, Sep 29, 2025 at 12:20:00PM +0200, Peter Eisentraut wrote:
> So I'm proposing to remove the Item type, replace it with void * in
> function prototypes, and remove all the casts.

The general idea seems reasonable to me, but I'm a little concerned that
using "void *" could break extensions written in C++ (see commit d5ca15e).
I haven't confirmed there's an actual issue here, though.

-- 
nathan

Commits

  1. Add some const qualifications

  2. Remove Item type

  3. Add type cast to foreach_internal's loop variable.