Re: [PATCH] Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statement

Mark Wong <markwkm@gmail.com>

From: Mark Wong <markwkm@gmail.com>

To: Akshay Joshi <akshay.joshi@enterprisedb.com>

Cc: Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-10-27T16:45:10Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid leaking system path from pg_available_extensions
- db5ed03217b9 19 (unreleased) cited
postgres_fdw, dblink: Validate use_scram_passthrough values
- 8a86aa313a71 19 (unreleased) cited
Make pg_get_expr() more bulletproof.
- 6867f963e319 15.0 cited

Attachments

for-optional-pretty.diff (text/plain) patch

Hi everyone,

On Thu, Oct 16, 2025 at 01:47:53PM +0530, Akshay Joshi wrote:
> 
> 
> On Wed, Oct 15, 2025 at 10:55 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
>     Hello,
> 
>     I have reviewed this patch before and provided a number of comments that
>     have been addressed by Akshay (so I encourage you to list my name and
>     this address in a Reviewed-by trailer line in the commit message).  One
>     thing I had not noticed is that while this function has a "pretty" flag,
>     it doesn't use it to pass anything to pg_get_expr_worker()'s prettyFlags
>     argument, and I think it should -- probably just
> 
>       prettyFlags = GET_PRETTY_FLAGS(pretty);
> 
>     same as pg_get_querydef() does.

Kinda sorta similar thought, I've noticed some existing functions like
pg_get_constraintdef make the "pretty" flag optional, so I'm wondering
if that scheme is also preferred here.

I've attached a small diff to the original
0001-Add-pg_get_policy_ddl-function-to-reconstruct-CREATE.patch to
illustrate the additional work to follow suit, if so desired.

Regards,
Mark
--
Mark Wong <markwkm@gmail.com>
EDB https://enterprisedb.com