Re: make -C src/test/isolation failure in index-killtuples due to btree_gist
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-18T23:15:06Z
Lists: pgsql-hackers
On Mon, Aug 18, 2025 at 11:38:02AM -0400, Tom Lane wrote: > Andres Freund <andres@anarazel.de> writes: >> No, it makes absolutely no sense to test e.g. hash killtuples support in >> btree_gist. > > I think the complaint is that nothing has been done to ensure that > these modules have been installed. You created a new dependency that > developers have to work around, rather than teaching the build system > to handle it. As a comparison point, all of the tests in > src/test/recovery, src/test/authentication, etc take care to install > required modules when you say "make check" in those directories. > You broke that for src/test/isolation, and you should fix it. > It shouldn't be much harder than setting EXTRA_INSTALL in the > Makefile case; I dunno about meson. All these test suites can rely on EXTRA_INSTALL because they rely on the check/installcheck rules from Makefile.global, where checkprep is pulled in. src/test/isolation defines its own check rules, so we would need a trick similar to what was done before b1720fe63f34. -- Michael
Commits
-
Move isolation test index-killtuples to src/test/modules/index/
- e429c3cecb4a 19 (unreleased) landed