Re: Sequence Access Methods, round two

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Kirill Reshke <reshkekirill@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Peter Smith <smithpb2250@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-18T23:28:07Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor init_params() in sequence.c to not use FormData_pg_sequence_data
- ba3d93b2e806 19 (unreleased) landed
Fix comment thinko in sequence.c
- 17a3f79f812c 17.0 landed
Group more closely cache updates for backends in sequence.c
- 6e951bf98e2e 17.0 landed
Introduce sequence_*() access functions
- 449e798c77ed 17.0 landed

On Mon, Aug 18, 2025 at 06:15:05PM +0500, Kirill Reshke wrote:
> Yes, this resonates with me better.

After sleeping on it, yes, perhaps that's the right move.
test_ddl_deparse reports the attributes as related to a sequence, but
it's really how this is handled internally anyway with the internal
call of DefineRelation().  This entirely decouples the relation
creation and the creation of its attributes.

> @@ -3365,7 +3365,7 @@ match_previous_words(int pattern_id,
>                 COMPLETE_WITH("TYPE");
>         /* Complete "CREATE ACCESS METHOD <name> TYPE" */
>         else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny, "TYPE"))
> -               COMPLETE_WITH("INDEX", "TABLE");
> +               COMPLETE_WITH("INDEX", "TABLE", "SEQUENCE");
>         /* Complete "CREATE ACCESS METHOD <name> TYPE <type>" */
>         else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny,
> "TYPE", MatchAny))
>                 COMPLETE_WITH("HANDLER");

Right, thanks.
--
Michael