Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com

Date: 2025-08-18T06:58:45Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.
- 24e74b9621e4 14.20 landed
- 12b0c0e51b2f 13.23 landed
- 4a08603a2322 15.15 landed
- 5a9af48689dc 16.11 landed
- 2bb84ea7ef89 17.7 landed
- b14144325984 18.1 landed
- 12609fbacb00 19 (unreleased) landed

On Fri, Aug 08, 2025 at 12:15:19AM -0700, Masahiko Sawada wrote:
> On Thu, Aug 7, 2025 at 4:39 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Thu, Aug 07, 2025 at 10:29:41AM -0700, Masahiko Sawada wrote:
> > > Yes, it's definitely possible to create the test using isolation. I
> > > wasn't sure how to invoke isolation tests only when injection points
> > > are enabled.
> >
> > For meson, I think that I would tweak the isolation test list based on
> > get_option('injection_points'), and do a similar thing for Makefile.
> 
> Thank you for the advice! I've changed the regression tests to use
> isolation tests.

That's enough to reproduce the MULL pointer dereference, thanks!

I would suggest to add a description at the top of foreign_recheck,
documenting the purpose of the test.

+# "s0_lock" execute a FOR UPDATE query but it stops before locking the result 
s/execute/executes/, with an 's'.

Fujita-san, are you planning to look at the proposal?
--
Michael