Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-18T01:10:40Z

Lists: pgsql-hackers

On Mon, Aug 18, 2025 at 12:56:02PM +1200, David Rowley wrote:
> One last thing, in order to inform people of breakages sooner than a
> post-commit report from the buildfarm, I wondered is if we should do:
> 
> -#ifdef HASH_DEBUG
> +#if defined(HASH_DEBUG) || defined(USE_ASSERT_CHECKING)
> 
> The HASH_DEBUG does not add any extra fields, so the overhead only
> amounts to the elog(DEBUG4) line.  HASH_STATISTICS adds extra fields
> and counter incrementing, so I don't propose the same treatment for
> that.

If we do that, I guess that we could just remove HASH_DEBUG, keeping
only HASH_STATISTICS.
--
Michael

Commits

Remove HASH_DEBUG output from dynahash.c
- a98ccf727ebb 19 (unreleased) landed
Use elog(DEBUG4) for dynahash.c statistics output
- 05fcb9667c37 19 (unreleased) landed
Fix invalid format string in HASH_DEBUG code
- 2c7c08a090f2 14.20 landed
- 199a347d29e5 15.15 landed
- d809494cdfc5 16.11 landed
- 04b384b3efb2 17.7 landed
- 1571c7ca5dc9 18.0 landed
- 296cba276081 19 (unreleased) landed
Fix failing -D HASH_STATISTICS builds
- efe705b05cc1 17.7 landed
- e4ba326295c5 18.0 landed
- ca38912512a9 19 (unreleased) landed
Refactor initial hash lookup in dynahash.c
- cc5ef90edd80 17.0 cited
Remove large fill factor support from dynahash.c.
- be0a6666656e 14.0 cited
Remove broken and useless entry-count printing in HASH_DEBUG code.
- 9d4e56699957 10.0 cited
Partition the freelist for shared dynahash tables.
- 44ca4022f3f9 9.6.0 cited