Re: Non-reproducible AIO failure

Kenneth Marshall <ktm@rice.edu>

From: Ken Marshall <ktm@rice.edu>

To: Konstantin Knizhnik <knizhnik@garret.ru>

Cc: Andres Freund <andres@anarazel.de>, Nico Williams <nico@cryptonector.com>, Thomas Munro <thomas.munro@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, rmt@lists.postgresql.org

Date: 2025-08-26T14:15:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

aio: Stop using enum bitfields due to bad code generation
- ce161b194e84 18.0 landed
- 5865150b6d53 19 (unreleased) landed
amcheck: Fix posting tree checks in gin_index_check()
- 0cf205e122ae 18.0 cited
aio: Add missing memory barrier when waiting for IO handle
- e9a3615a5224 18.0 landed

On Tue, Aug 26, 2025 at 04:59:54PM +0300, Konstantin Knizhnik wrote:
> 
> > But we have observed the generated code being pretty grotty and it's caused
> > more than enough confusion - so let's just replace them with plain uint8's and
> > cast in switches.
> 
> +1
> 
> May be I am wrong, but it seems to me that after add-moissing-memory-barrier
> patch was applied nobody reproduced assertion failure with replaced
> bitfields.
> 

Hi,

I am just a lurker but that was what I saw happen too. No problem with
the replaced bitfields.

Regards,
Ken