Re: Dead code with short varlenas in toast_save_datum()

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>

Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-10T10:35:13Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add isolation test for TOAST value reuse during CLUSTER
- f57e214d1cbb 19 (unreleased) landed
Add SQL test for TOAST value allocations on rewrite
- 69f75d671475 19 (unreleased) landed
Add regression test for short varlenas saved in TOAST relations
- 225ebfe30a1a 19 (unreleased) landed

On Sun, Aug 10, 2025 at 03:08:14AM -0700, Nikhil Kumar Veldanda wrote:
> I’m sending a small test-only patch that increases test coverage for
> toast_internals.c from 88.5% -> 95.8%.

(Discussed these ones offline, while looking at the coverage of
toast_internals.c.)

Thanks for compiling a patch to close more the coverage gap.  I'll
look at what you have here.
--
Michael