Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com

Date: 2025-08-07T03:38:55Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.
- 24e74b9621e4 14.20 landed
- 12b0c0e51b2f 13.23 landed
- 4a08603a2322 15.15 landed
- 5a9af48689dc 16.11 landed
- 2bb84ea7ef89 17.7 landed
- b14144325984 18.1 landed
- 12609fbacb00 19 (unreleased) landed

On Tue, Aug 05, 2025 at 11:00:54AM -0700, Masahiko Sawada wrote:
> The attached patch includes the draft fix and regression tests (using
> injection points).

+$psql_session->query_safe(qq[
+    select injection_points_set_local();
+    select injection_points_attach('heapam_lock_tuple-before-lock', 'wait');
+]);

It seems to me that an isolation test would be a better fit here.  TAP
tests are usually a good fit for injection points if you need to do
direct node manipulations, like restarts or stops.  The whole test
posted only does SQL-ish things, and you could rely on a loopback
server as we do in the SQL tests of postgres_fdw?
--
Michael