Horton

Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Jim Nasby <jnasby@upgrade.com>
Cc: "Burd, Greg" <greg@burd.me>, Nikita Malakhov <hukutoc@gmail.com>, Hannu Krosing <hannuk@google.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-08-06T23:16:28Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add data type oid8, 64-bit unsigned identifier

On Mon, Aug 04, 2025 at 02:37:19PM -0500, Jim Nasby wrote:
> On Fri, Aug 1, 2025 at 4:03 AM Michael Paquier <michael@paquier.xyz> wrote:
>> - Addition of separate patch to rename varatt_external to
>> varatt_external_oid and VARTAG_ONDISK to VARTAG_ONDISK_OID, in 0003.
> 
> Since you're already renaming things... ISTM "ondisk" has the potential for
> confusion, assuming that at some point we'll have the ability to store
> large datums directly in the filesystem (instead of breaking into chunks to
> live in a relation). VARTAG_DURABLE might be a better option.

Hmm.  I don't know about this one.  Durable is an ACID property that
does not apply to all relation kinds.  For example, take an unlogged
table: its data is not durable but its TOAST pointers would be marked
with a VARTAG_DURABLE.  With that in mind ONDISK still sounds kind of
OK for me to use as a name.
--
Michael