Re: Improve error reporting in 027_stream_regress test
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2025-07-29T06:06:54Z
Lists: pgsql-hackers
Attachments
- 0001-Add-optional-timeout-to-pg_isready-call-for-TAP-test.patch (text/x-diff) patch 0001
On Tue, Jul 29, 2025 at 12:41:39AM -0400, Tom Lane wrote: > Alexander Lakhin <exclusion@gmail.com> writes: > > The new check has failed on mamba [1], apparently because this animal is > > too slow for pg_isready: > > There is something strange happening on mamba --- not sure what, > but its cycle time for the past week has been a lot more than normal. > I plan to power-cycle it tomorrow and see if that does anything. > In the meantime, I'd not put a lot of stock in that failure. As far as I can see, based on the logs, the standby seems to be lagging behind in terms of replay. Anyway, a consistent state is reached way before the pg_isready call is done (07:37:27 vs 08:01:50), so pg_isready should report something as the standby is ready for connections. And it's true that 3s would be very short in smallish environments. We are getting PQPING_NO_RESPONSE meaning a lack of report activity from the postmaster. An increase in timeout may help, but the host seems like it's facing a high workload so it's not really possible to come with a perfect number, just an estimation. How about adding a --timeout to pg_isready based on PGCONNECT_TIMEOUT, like in the attached? At least that would be more in line with the other tests, and we'd have more leverage over the timing of is_alive(). Default is 180s. -- Michael
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Improve error reporting of recovery test 027_stream_regress
- 47da198934e9 19 (unreleased) landed
-
Add PostgreSQL::Test::Cluster::read_head_tail() helper to PostgreSQL/Utils.pm
- b93f4e2f98b3 19 (unreleased) landed
-
Handle timeout in PostgreSQL::Test::Cluster::is_alive()
- cb833c1b6d19 19 (unreleased) landed
-
Check status of nodes after regression test run in 027_stream_regress
- 1e9b5140c44b 19 (unreleased) landed
-
Add PostgreSQL::Test::Cluster::is_alive()
- d4c9195eff41 19 (unreleased) landed