Thread

Re: Bogus bitmasking in heap2_desc

Julien Rouhaud <rjuju123@gmail.com> — 2025-07-28T05:31:15Z

Hi,

On Mon, Jul 28, 2025 at 02:27:43PM +0900, Michael Paquier wrote:
>
> The relationship between XLOG_HEAP_OPMASK and heap2 is documented in
> heapam_xlog.h.  XLOG_HEAP2_MULTI_INSERT may have XLOG_HEAP_INIT_PAGE
> set, so if we don't filter the contents from XLogRecGetInfo() then the
> record description becomes incorrect for the XLOG_HEAP2_MULTI_INSERT
> "MULTI_INSERT+INIT" case, no?
>
> Apologies if I am missing your point.

Ah I'm the one apologizing, I totally missed that comment.

Thanks for the pointing it out.