Thread

Re: Wrong datatype used in visibilitymap_get_status

Julien Rouhaud <rjuju123@gmail.com> — 2025-07-24T22:11:15Z

On Thu, Jul 24, 2025 at 09:56:00AM -0500, Nathan Bossart wrote:
> On Thu, Jul 24, 2025 at 03:50:17PM +0800, Julien Rouhaud wrote:
> > I was reading the visibility map code and noticed that
> > visibilitymap_get_status() wasn't updated in a892234f830e AFAICS (Cc Robert and
> > Sawada-san) to return an empty set of flags rather than false in one code path,
> > so simple patch attached.  Both have the same value so that likely explains why
> > it got unnoticed until now, although I assume that some compiler would
> > have eventually started to complain about that.
>
> +1, I'll go commit this.

Thanks.