Horton

Re: [PATCH] Add tests for binaryheap.c

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-16T19:34:13Z
Lists: pgsql-hackers

Attachments

On Fri, Jun 27, 2025 at 02:02:22PM +0300, Aleksander Alekseev wrote:
>> I'm not sure I see much point in testing both min-heaps and max-heaps.  The
>> only difference between the two is in the comparator, so IMHO the extra
>> tests really only serve to test the test comparator.
> 
> Make sense. Here is the corrected patch.

I trimmed this down some more while trying to keep the coverage the same.

-- 
nathan

Commits

  1. Add a test harness for the binary heap code.