Horton

Thread

Commits

  1. Remove XLogCtl->ckptFullXid.

  2. Add basic infrastructure for 64 bit transaction IDs.

  1. XLogCtl->ckptFullXid is unused

    Nathan Bossart <nathandbossart@gmail.com> — 2025-07-11T20:20:35Z

    I just noticed $SUBJECT.  This seems to be an oversight in commit 2fc7af5,
which simultaneously combined ckptXidEpoch and ckptXid into ckptFullXid and
removed the only use of that information, i.e., GetNextXidAndEpoch().  Any
objections if I remove it now?

-- 
nathan

  2. Re: XLogCtl->ckptFullXid is unused

    Aleksander Alekseev <aleksander@tigerdata.com> — 2025-07-11T21:32:31Z

    Hi Nathan,

> I just noticed $SUBJECT.  This seems to be an oversight in commit 2fc7af5,
> which simultaneously combined ckptXidEpoch and ckptXid into ckptFullXid
and
> removed the only use of that information, i.e., GetNextXidAndEpoch().  Any
> objections if I remove it now?

Good catch. I don't see any reason why we might want to keep ckptFullXid.
Also I checked if there are any references left to this field - there are
none.

  3. Re: XLogCtl->ckptFullXid is unused

    Nathan Bossart <nathandbossart@gmail.com> — 2025-07-12T19:36:05Z

    On Sat, Jul 12, 2025 at 12:32:31AM +0300, Aleksander Alekseev wrote:
> Good catch. I don't see any reason why we might want to keep ckptFullXid.
> Also I checked if there are any references left to this field - there are
> none.

Thanks, committed.

-- 
nathan